echauchot commented on code in PR #35: URL: https://github.com/apache/flink-connector-cassandra/pull/35#discussion_r2318553436
########## flink-connector-cassandra/src/main/java/org/apache/flink/connector/cassandra/table/mapper/CassandraFieldMapperFactory.java: ########## @@ -0,0 +1,169 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.connector.cassandra.table.mapper; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.table.types.logical.ArrayType; +import org.apache.flink.table.types.logical.DecimalType; +import org.apache.flink.table.types.logical.LogicalType; +import org.apache.flink.table.types.logical.LogicalTypeRoot; +import org.apache.flink.table.types.logical.MapType; +import org.apache.flink.table.types.logical.MultisetType; +import org.apache.flink.table.types.logical.RowType; + +/** Factory for creating appropriate field mappers based on Flink logical types. */ +@Internal +public final class CassandraFieldMapperFactory { + + private CassandraFieldMapperFactory() {} + + /** + * Creates a field mapper for the given logical type. Different mappers for different {@link + * com.datastax.driver.core.DataType} + * + * @param logicalType the Flink logical type + * @return appropriate field mapper for the type + */ + public static CassandraFieldMapper createFieldMapper(LogicalType logicalType) { + LogicalTypeRoot typeRoot = logicalType.getTypeRoot(); + + switch (typeRoot) { + // Supported primitive types + case BOOLEAN: + return new PrimitiveFieldMappers.BooleanMapper(); + case TINYINT: + return new PrimitiveFieldMappers.ByteMapper(); + case SMALLINT: + return new PrimitiveFieldMappers.ShortMapper(); + case INTEGER: + return new PrimitiveFieldMappers.IntegerMapper(); + case BIGINT: Review Comment: I did not know that, thanks for the reference ! In that case, no overflow so I'm resolving -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
