snuyanzin commented on code in PR #26959:
URL: https://github.com/apache/flink/pull/26959#discussion_r2319981372
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/physical/stream/PushCalcPastChangelogNormalizeRule.java:
##########
@@ -326,8 +326,11 @@ private void transformWithRemainingPredicates(
}
if (!conditions.isEmpty()) {
final RexNode condition = relBuilder.and(conditions);
- programBuilder.addCondition(
- FlinkRexUtil.simplify(relBuilder.getRexBuilder(),
condition, rexExecutor));
+ final RexNode simplifiedCondition =
+ FlinkRexUtil.simplify(relBuilder.getRexBuilder(),
condition, rexExecutor);
+ if (!condition.isAlwaysTrue()) {
+
programBuilder.addCondition(adjustInputRef(simplifiedCondition,
inputRefMapping));
Review Comment:
need adjusting as it was done several lines above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
