Mrart commented on code in PR #4113:
URL: https://github.com/apache/flink-cdc/pull/4113#discussion_r2320673516
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-postgres-cdc/src/main/java/org/apache/flink/cdc/connectors/postgres/source/fetch/PostgresSourceFetchTaskContext.java:
##########
@@ -148,8 +148,11 @@ public void configure(SourceSplitBase sourceSplitBase) {
dbzConfig
.getConfig()
.edit()
- // never drop slot for stream split, which
is also global split
- .with(DROP_SLOT_ON_STOP.name(), false)
+ // When startup.mode='snapshot' drop slot
for stream split,
+ // which is also global split
Review Comment:
In our current implementation of deleting backfill slots, in snapshot mode,
there is no need to restart. You just have to run it again with overwrite mode？
Also Streaming job，It's the same thing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
