Poorvankbhatia commented on code in PR #37:
URL:
https://github.com/apache/flink-connector-cassandra/pull/37#discussion_r2328693975
##########
flink-connector-cassandra/src/test/java/org/apache/flink/connector/cassandra/CassandraTestEnvironment.java:
##########
@@ -173,7 +201,8 @@ private void stopEnv() {
if (cluster != null) {
cluster.close();
}
- cassandraContainer.stop();
+ cassandraContainer1.stop();
Review Comment:
Should we wrap each container.stop() call in a separate try-catch block to
ensure both containers are stopped even if one fails.
##########
flink-connector-cassandra/src/test/resources/cassandra.yml:
##########
@@ -0,0 +1,1419 @@
+
Review Comment:
Is this file used anywhere? So do we require both .yaml and .yml files?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
