Efrat19 commented on code in PR #26985:
URL: https://github.com/apache/flink/pull/26985#discussion_r2347291747
##########
flink-core/src/main/java/org/apache/flink/configuration/TraceOptions.java:
##########
@@ -67,6 +82,19 @@ public static Configuration forReporter(Configuration
configuration, String repo
+ " any of the names in the list will be
started. Otherwise, all reporters that could be found in"
+ " the configuration will be started.");
+ /** The detail level for reporting checkpoint spans. */
+ public static final ConfigOption<TraceOptions.CheckpointSpanDetailLevel>
+ CHECKPOINT_SPAN_DETAIL_LEVEL =
+ key("traces.checkpoint.span-detail-level")
+
.enumType(TraceOptions.CheckpointSpanDetailLevel.class)
+
.defaultValue(CheckpointSpanDetailLevel.SPANS_PER_CHECKPOINT)
+ .withDescription(
+ "Detail level for reporting checkpoint
spans. Possible values:\n"
+ + "- SPAN_PER_CHECKPOINT
(default): Single span per checkpoint. Aggregated sum/max for submetrics from
all tasks and subtasks per checkpoint\n"
+ + "-
SPAN_PER_CHECKPOINT_WITH_TASKS: Single span per checkpoint. Same as
SPAN_PER_CHECKPOINT, plus arrays of aggregated values per task.\n"
+ + "- SPANS_PER_TASK: Same as
SPAN_PER_CHECKPOINT plus children spans per each task. Each task span with
aggregated sum/max submetrics from subtasks.\n"
Review Comment:
```suggestion
"Detail level for reporting checkpoint
spans. Possible values:\n"
+ "- SPANS_PER_CHECKPOINT
(default): Single span per checkpoint. Aggregated sum/max for submetrics from
all tasks and subtasks per checkpoint\n"
+ "-
SPANS_PER_CHECKPOINT_WITH_TASKS: Single span per checkpoint. Same as
SPANS_PER_CHECKPOINT, plus arrays of aggregated values per task.\n"
+ "- SPANS_PER_TASK: Same as
SPAN_PER_CHECKPOINT plus children spans per each task. Each task span with
aggregated sum/max submetrics from subtasks.\n"
```
##########
flink-core/src/main/java/org/apache/flink/configuration/TraceOptions.java:
##########
@@ -67,6 +82,19 @@ public static Configuration forReporter(Configuration
configuration, String repo
+ " any of the names in the list will be
started. Otherwise, all reporters that could be found in"
+ " the configuration will be started.");
+ /** The detail level for reporting checkpoint spans. */
+ public static final ConfigOption<TraceOptions.CheckpointSpanDetailLevel>
+ CHECKPOINT_SPAN_DETAIL_LEVEL =
+ key("traces.checkpoint.span-detail-level")
+
.enumType(TraceOptions.CheckpointSpanDetailLevel.class)
+
.defaultValue(CheckpointSpanDetailLevel.SPANS_PER_CHECKPOINT)
+ .withDescription(
+ "Detail level for reporting checkpoint
spans. Possible values:\n"
+ + "- SPAN_PER_CHECKPOINT
(default): Single span per checkpoint. Aggregated sum/max for submetrics from
all tasks and subtasks per checkpoint\n"
+ + "-
SPAN_PER_CHECKPOINT_WITH_TASKS: Single span per checkpoint. Same as
SPAN_PER_CHECKPOINT, plus arrays of aggregated values per task.\n"
+ + "- SPANS_PER_TASK: Same as
SPAN_PER_CHECKPOINT plus children spans per each task. Each task span with
aggregated sum/max submetrics from subtasks.\n"
Review Comment:
```suggestion
"Detail level for reporting checkpoint
spans. Possible values:\n"
+ "- SPANS_PER_CHECKPOINT
(default): Single span per checkpoint. Aggregated sum/max for submetrics from
all tasks and subtasks per checkpoint\n"
+ "-
SPANS_PER_CHECKPOINT_WITH_TASKS: Single span per checkpoint. Same as
SPANS_PER_CHECKPOINT, plus arrays of aggregated values per task.\n"
+ "- SPANS_PER_TASK: Same as
SPAN_PER_CHECKPOINT plus children spans per each task. Each task span with
aggregated sum/max submetrics from subtasks.\n"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
