Sxnan commented on code in PR #138: URL: https://github.com/apache/flink-agents/pull/138#discussion_r2354217315
########## runtime/src/main/java/org/apache/flink/agents/runtime/actionstate/ActionStateUtil.java: ########## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.flink.agents.runtime.actionstate; + +import org.apache.flink.agents.api.Event; +import org.apache.flink.agents.plan.Action; + +import java.nio.charset.StandardCharsets; +import java.util.UUID; + +/** Utility class for action state related operations. */ +public class ActionStateUtil { + + public static String generateKey(Object key, Action action, Event event) { + return key + + "-" + + UUID.nameUUIDFromBytes( Review Comment: I think key generation should not include the uuid from the event, the uuid is randomly generated. And it is currently not generated with a per-key sequence number. For that sequence number, I think we can use the Flink state to store a monotonically increasing number, assign and increase the number whenever an input event arrives. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
