Github user KurtYoung commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3062#discussion_r95427718
  
    --- Diff: tools/maven/suppressions.xml ---
    @@ -23,6 +23,8 @@ under the License.
                "http://www.puppycrawl.com/dtds/suppressions_1_1.dtd";>
     
     <suppressions>
    -           <suppress 
files="org[\\/]apache[\\/]flink[\\/]api[\\/]io[\\/]avro[\\/]example[\\/]User.java"
 checks="[a-zA-Z0-9]*"/>
    -           <suppress 
files="org[\\/]apache[\\/]flink[\\/]api[\\/]io[\\/]avro[\\/]generated[\\/].*.java"
 checks="[a-zA-Z0-9]*"/>
    +    <suppress 
files="org[\\/]apache[\\/]flink[\\/]api[\\/]io[\\/]avro[\\/]example[\\/]User.java"
 checks="[a-zA-Z0-9]*"/>
    --- End diff --
    
    Since the classes i copied are violating multiple style check rules, and it 
looks like disabling multiple rules isn't working as i wanted, so i think i 
still need to change the suppression file. Will also clean this up once we 
update Calcite version


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to