RocMarshal commented on code in PR #26985:
URL: https://github.com/apache/flink/pull/26985#discussion_r2358580198
##########
flink-core/src/main/java/org/apache/flink/configuration/TraceOptions.java:
##########
@@ -67,6 +82,31 @@ public static Configuration forReporter(Configuration
configuration, String repo
+ " any of the names in the list will be
started. Otherwise, all reporters that could be found in"
+ " the configuration will be started.");
+ /** The detail level for reporting checkpoint spans. */
+ public static final ConfigOption<TraceOptions.CheckpointSpanDetailLevel>
+ CHECKPOINT_SPAN_DETAIL_LEVEL =
+ key("traces.checkpoint.span-detail-level")
+
.enumType(TraceOptions.CheckpointSpanDetailLevel.class)
+
.defaultValue(CheckpointSpanDetailLevel.SPAN_PER_CHECKPOINT)
+ .withDescription(
+ String.format(
+ "Detail level for reporting
checkpoint spans. Possible values:\n"
+ + "- %s (default): Single
span per checkpoint. Aggregated sum/max for submetrics from all tasks and
subtasks per checkpoint\n"
+ + "- %s: Single span per
checkpoint. Same as %s, plus arrays of aggregated values per task.\n"
+ + "- %s: Same as %s plus
children spans per each task. Each task span with aggregated sum/max submetrics
from subtasks.\n"
+ + "- %s: Same as %s plus
children spans per each subtask. Child spans for tasks and grand-child spans
for subtasks.",
+
CheckpointSpanDetailLevel.SPAN_PER_CHECKPOINT.name(),
+
CheckpointSpanDetailLevel.SPAN_PER_CHECKPOINT_WITH_TASKS
+ .name(),
+
CheckpointSpanDetailLevel.SPAN_PER_CHECKPOINT.name(),
+
CheckpointSpanDetailLevel.CHILDREN_SPANS_PER_TASK
+ .name(),
+
CheckpointSpanDetailLevel.SPAN_PER_CHECKPOINT.name(),
+
CheckpointSpanDetailLevel.CHILDREN_SPANS_PER_SUBTASK
+ .name(),
+
CheckpointSpanDetailLevel.CHILDREN_SPANS_PER_TASK
Review Comment:
Could we use the APIs 'Description.builder().list() ... ' to constructs the
description ?
Such as PipelineOptions#SERIALIZATION_CONFIG...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
