snuyanzin commented on code in PR #26934:
URL: https://github.com/apache/flink/pull/26934#discussion_r2365560369
##########
flink-clients/src/test/java/org/apache/flink/client/program/DefaultPackagedProgramRetrieverITCase.java:
##########
@@ -394,17 +393,19 @@ void
testWithJobClassAndMultipleEntryClassesOnSystemClasspath()
}
@Test
- void testRetrieveCorrectUserClasspathsWithoutSpecifiedEntryClass()
- throws IOException, FlinkException, ProgramInvocationException {
+ void testRetrieveCorrectUserClasspathsWithoutSpecifiedEntryClass() throws
Exception {
final PackagedProgramRetriever retrieverUnderTest =
DefaultPackagedProgramRetriever.create(
singleEntryClassClasspathProvider.getDirectory(),
null,
ClasspathProviderExtension.parametersForTestJob("suffix"),
new Configuration());
- final JobGraph jobGraph = retrieveJobGraph(retrieverUnderTest, new
Configuration());
+ final StreamGraph streamGraph =
+ retrieveStreamGraph(retrieverUnderTest, new Configuration());
final List<String> actualClasspath =
-
jobGraph.getClasspaths().stream().map(URL::toString).collect(Collectors.toList());
+ streamGraph.getClasspaths().stream()
+ .map(URL::toString)
+ .collect(Collectors.toList());
Review Comment:
can we extract this
```java
streamGraph.getClasspaths().stream()
.map(URL::toString)
.collect(Collectors.toList());
```
into a separate method, it is duplicated in this class multiple times
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
