davidradl commented on code in PR #27017:
URL: https://github.com/apache/flink/pull/27017#discussion_r2369292647
##########
flink-core/src/main/java/org/apache/flink/types/variant/BinaryVariantInternalBuilder.java:
##########
@@ -290,7 +290,7 @@ public void appendTimestamp(long microsSinceEpoch) {
public void appendFloat(float f) {
checkCapacity(1 + 4);
writeBuffer[writePos++] = primitiveHeader(FLOAT);
- writeLong(writeBuffer, writePos, Float.floatToIntBits(f), 8);
+ writeLong(writeBuffer, writePos, Float.floatToIntBits(f), 4);
Review Comment:
Hi,
Am I missing something? Long is 8 bytes and it is a writeLong. Could it be
that `checkCapacity(1 + 4);` is incorrect and it should be `checkCapacity(1 +
8);` Line 286 is a write long with 8 bytes
##########
flink-core/src/main/java/org/apache/flink/types/variant/BinaryVariantInternalBuilder.java:
##########
@@ -290,7 +290,7 @@ public void appendTimestamp(long microsSinceEpoch) {
public void appendFloat(float f) {
checkCapacity(1 + 4);
writeBuffer[writePos++] = primitiveHeader(FLOAT);
- writeLong(writeBuffer, writePos, Float.floatToIntBits(f), 8);
+ writeLong(writeBuffer, writePos, Float.floatToIntBits(f), 4);
Review Comment:
Am I missing something? Long is 8 bytes and it is a writeLong. Could it be
that `checkCapacity(1 + 4);` is incorrect and it should be `checkCapacity(1 +
8);` Line 286 is a write long with 8 bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
