Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2938#discussion_r95552283
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -517,22 +657,20 @@ object AggregateUtil {
private def createAggregateBufferDataType(
groupings: Array[Int],
aggregates: Array[Aggregate[_]],
- inputType: RelDataType): RowTypeInfo = {
+ inputType: RelDataType,
+ windowKeyType: Option[TypeInformation[_]] = None): RowTypeInfo = {
// get the field data types of group keys.
val groupingTypes: Seq[TypeInformation[_]] = groupings
.map(inputType.getFieldList.get(_).getType)
.map(FlinkTypeFactory.toTypeInfo)
- val aggPartialNameSuffix = "agg_buffer_"
- val factory = new SqlTypeFactoryImpl(RelDataTypeSystem.DEFAULT)
-
// get all field data types of all intermediate aggregates
val aggTypes: Seq[TypeInformation[_]] =
aggregates.flatMap(_.intermediateDataType)
// concat group key types and aggregation types
--- End diff --
Update comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
