jiexray commented on code in PR #27027: URL: https://github.com/apache/flink/pull/27027#discussion_r2381136948
########## flink-runtime/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/AsyncTriggerConvertable.java: ########## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.streaming.runtime.operators.windowing; + +import org.apache.flink.annotation.Internal; + +import javax.annotation.Nonnull; + +/** + * Interface for declaring the ability to convert a sync {@code Trigger} to {@code AsyncTrigger}. + * The trigger conversion happens in {@code AsyncTriggerConverter}. + */ +@Internal +public interface AsyncTriggerConvertable { Review Comment: Good idea! I refactor the APIs for converting `Trigger`, and union all of them in `AsyncTriggerConverter`. The two APIs are as follows: ``` public interface AsyncTriggerConverter { // Virtual member function: the implementation declares its own way to spawn `AsyncTrigger` // (for example, `ProcessingTimeoutTrigger`). Object convertToAsync(); // Static function: the enter point for converting any `Trigger` to `AsyncTrigger`. static AsyncTrigger convertToAsync(Trigger trigger); } ``` The integration of the two APIs are tested in `AsyncTriggerConverterTest` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
