snuyanzin commented on code in PR #27067: URL: https://github.com/apache/flink/pull/27067#discussion_r2390652553
########## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/converters/table/AbstractAlterTableConverter.java: ########## @@ -0,0 +1,172 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.planner.operations.converters.table; + +import org.apache.flink.sql.parser.ddl.SqlAlterTable; +import org.apache.flink.sql.parser.ddl.SqlAlterTableSchema; +import org.apache.flink.table.api.Schema; +import org.apache.flink.table.api.ValidationException; +import org.apache.flink.table.catalog.CatalogBaseTable; +import org.apache.flink.table.catalog.CatalogManager; +import org.apache.flink.table.catalog.CatalogTable; +import org.apache.flink.table.catalog.ContextResolvedTable; +import org.apache.flink.table.catalog.ObjectIdentifier; +import org.apache.flink.table.catalog.ResolvedCatalogTable; +import org.apache.flink.table.catalog.TableChange; +import org.apache.flink.table.catalog.TableDistribution; +import org.apache.flink.table.catalog.UnresolvedIdentifier; +import org.apache.flink.table.operations.NopOperation; +import org.apache.flink.table.operations.Operation; +import org.apache.flink.table.operations.ddl.AlterTableChangeOperation; +import org.apache.flink.table.operations.utils.ValidationUtils; +import org.apache.flink.table.planner.operations.converters.SqlNodeConverter; +import org.apache.flink.table.planner.utils.OperationConverterUtils; + +import org.apache.calcite.sql.SqlIdentifier; + +import java.util.List; +import java.util.Optional; +import java.util.function.BiConsumer; +import java.util.function.Function; +import java.util.stream.Collectors; + +/** Abstract class for ALTER TABLE converters. */ +public abstract class AbstractAlterTableConverter<T extends SqlAlterTable> + implements SqlNodeConverter<T> { + protected static final String EX_MSG_PREFIX = "Failed to execute ALTER TABLE statement.\n"; + + protected abstract Operation convertToOperation( + T sqlAlterTable, ResolvedCatalogTable oldTable, ConvertContext context); + + @Override + public Operation convertSqlNode(T sqlAlterTable, ConvertContext context) { + CatalogManager catalogManager = context.getCatalogManager(); + final ObjectIdentifier tableIdentifier = getIdentifier(sqlAlterTable, context); + Optional<ContextResolvedTable> optionalCatalogTable = + catalogManager.getTable(tableIdentifier); + + if (optionalCatalogTable.isEmpty() || optionalCatalogTable.get().isTemporary()) { + if (sqlAlterTable.ifTableExists()) { + return new NopOperation(); + } + throw new ValidationException( + String.format( + "Table %s doesn't exist or is a temporary table.", tableIdentifier)); + } + ValidationUtils.validateTableKind( + optionalCatalogTable.get().getTable(), + CatalogBaseTable.TableKind.TABLE, + "alter table"); + + return convertToOperation( + sqlAlterTable, optionalCatalogTable.get().getResolvedTable(), context); + } Review Comment: Moved from `SqlNodeToOperationConversion` https://github.com/apache/flink/blob/538c24c8bf490eb8870c4d39c8ac5b204d3613ee/flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/SqlNodeToOperationConversion.java#L393-L410 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
