rkhachatryan commented on code in PR #27035: URL: https://github.com/apache/flink/pull/27035#discussion_r2387240656
########## flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/state/rocksdb/restore/RestoredDBInstance.java: ########## @@ -0,0 +1,167 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.state.rocksdb.restore; + +import org.apache.flink.runtime.state.IncrementalLocalKeyedStateHandle; +import org.apache.flink.runtime.state.RegisteredStateMetaInfoBase; +import org.apache.flink.runtime.state.metainfo.StateMetaInfoSnapshot; +import org.apache.flink.state.rocksdb.RocksDBOperationUtils; +import org.apache.flink.state.rocksdb.ttl.RocksDbTtlCompactFiltersManager; +import org.apache.flink.util.IOUtils; + +import org.rocksdb.ColumnFamilyDescriptor; +import org.rocksdb.ColumnFamilyHandle; +import org.rocksdb.ColumnFamilyOptions; +import org.rocksdb.DBOptions; +import org.rocksdb.ReadOptions; +import org.rocksdb.RocksDB; + +import javax.annotation.Nonnull; + +import java.nio.file.Path; +import java.util.ArrayList; +import java.util.List; +import java.util.function.Function; + +/** Restored DB instance containing all necessary handles and metadata. */ +public class RestoredDBInstance implements AutoCloseable { + + @Nonnull public final RocksDB db; + @Nonnull public final ColumnFamilyHandle defaultColumnFamilyHandle; + @Nonnull public final List<ColumnFamilyHandle> columnFamilyHandles; + @Nonnull public final List<ColumnFamilyDescriptor> columnFamilyDescriptors; + @Nonnull public final List<StateMetaInfoSnapshot> stateMetaInfoSnapshots; + public final ReadOptions readOptions; + public final IncrementalLocalKeyedStateHandle srcStateHandle; + + public RestoredDBInstance( + @Nonnull RocksDB db, + @Nonnull List<ColumnFamilyHandle> columnFamilyHandles, + @Nonnull List<ColumnFamilyDescriptor> columnFamilyDescriptors, + @Nonnull List<StateMetaInfoSnapshot> stateMetaInfoSnapshots, + IncrementalLocalKeyedStateHandle srcStateHandle) { + this.db = db; + this.defaultColumnFamilyHandle = columnFamilyHandles.remove(0); + this.columnFamilyHandles = columnFamilyHandles; + this.columnFamilyDescriptors = columnFamilyDescriptors; + this.stateMetaInfoSnapshots = stateMetaInfoSnapshots; + this.readOptions = new ReadOptions(); + this.srcStateHandle = srcStateHandle; + } + + @Override + public void close() { + List<ColumnFamilyOptions> columnFamilyOptions = + new ArrayList<>(columnFamilyDescriptors.size() + 1); + columnFamilyDescriptors.forEach((cfd) -> columnFamilyOptions.add(cfd.getOptions())); + RocksDBOperationUtils.addColumnFamilyOptionsToCloseLater( + columnFamilyOptions, defaultColumnFamilyHandle); + IOUtils.closeQuietly(defaultColumnFamilyHandle); + IOUtils.closeAllQuietly(columnFamilyHandles); + IOUtils.closeQuietly(db); + IOUtils.closeAllQuietly(columnFamilyOptions); + IOUtils.closeQuietly(readOptions); + } + + /** + * Restores a RocksDB instance from local state for the given state handle. + * + * @param stateHandle the state handle to restore from + * @param columnFamilyOptionsFactory factory for creating column family options + * @param dbOptions database options + * @param ttlCompactFiltersManager TTL compact filters manager (can be null) + * @param writeBufferManagerCapacity write buffer manager capacity (can be null) + * @return restored DB instance with all necessary handles and metadata + * @throws Exception on any restore error + */ + public static RestoredDBInstance restoreTempDBInstanceFromLocalState( + IncrementalLocalKeyedStateHandle stateHandle, + List<StateMetaInfoSnapshot> stateMetaInfoSnapshots, + Function<String, ColumnFamilyOptions> columnFamilyOptionsFactory, + DBOptions dbOptions, + RocksDbTtlCompactFiltersManager ttlCompactFiltersManager, + Long writeBufferManagerCapacity) + throws Exception { + + List<ColumnFamilyDescriptor> columnFamilyDescriptors = + createColumnFamilyDescriptors( + stateMetaInfoSnapshots, + columnFamilyOptionsFactory, + ttlCompactFiltersManager, + writeBufferManagerCapacity, + true); Review Comment: Shouldn't the value for the last argument `registerTtlCompactFilter` be `false` here? In the original version, `restoreTempDBInstanceFromLocalState` passes `false` IIUC. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
