1996fanrui commented on code in PR #27069:
URL: https://github.com/apache/flink/pull/27069#discussion_r2392736832
##########
flink-runtime/src/main/java/org/apache/flink/runtime/state/KeyedStateBackend.java:
##########
@@ -166,6 +167,15 @@ default boolean isSafeToReuseKVState() {
return false;
}
+ /**
+ * @return fixed lower-case string identifying the type of the underlying
state backend, e.g.
+ * rocksdb, hashmap, or unknown.
+ */
+ @Experimental
+ default String getBackendTypeIdentifier() {
+ return "unknown";
+ }
Review Comment:
Why not change the implementations? For example, `RocksDBKeyedStateBackend`
returns `rocksdb`, `HeapKeyedStateBackend` returns `hashmap`
##########
flink-runtime/src/main/java/org/apache/flink/runtime/state/AsyncKeyedStateBackend.java:
##########
@@ -140,4 +141,13 @@ default boolean isSafeToReuseKVState() {
@Override
void dispose();
+
+ /**
+ * @return fixed lower-case string identifying the type of the underlying
state backend, e.g.
+ * rocksdb, hashmap, or unknown.
Review Comment:
Is forst missed?
```suggestion
* rocksdb, hashmap, forst or unknown.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
