alnzng commented on code in PR #195:
URL: https://github.com/apache/flink-agents/pull/195#discussion_r2378106300
##########
python/flink_agents/integrations/chat_models/anthropic/anthropic_chat_model.py:
##########
@@ -210,6 +210,12 @@ class AnthropicChatModelSetup(BaseChatModelSetup):
Attributes:
----------
+ connection : str
Review Comment:
Thanks for the reply @GreatEugenius!
I appreciate the explanation, though I'm still not fully convinced of the
necessity. Since we're building comprehensive documentation that will list all
available attributes(including inherited ones), users should have visibility
into all options without needing to check the docstrings. For (advanced)
developers who do read the source codes directly, checking parent classes for
inherited attributes is standard practice.
However, I'm ok with it if that's the team's decision.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
