AHeise commented on code in PR #192:
URL:
https://github.com/apache/flink-connector-kafka/pull/192#discussion_r2409595432
##########
flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/source/enumerator/KafkaSourceEnumeratorTest.java:
##########
@@ -662,63 +688,84 @@ private void verifyLastReadersAssignments(
Collection<Integer> readers,
Set<String> topics,
int expectedAssignmentSeqSize) {
+ verifyLastReadersAssignments(
+ context, readers, topics, expectedAssignmentSeqSize,
OffsetsInitializer.earliest());
+ }
+
+ private void verifyLastReadersAssignments(
+ MockSplitEnumeratorContext<KafkaPartitionSplit> context,
+ Collection<Integer> readers,
+ Set<String> topics,
+ int expectedAssignmentSeqSize,
+ OffsetsInitializer offsetsInitializer) {
verifyAssignments(
- getExpectedAssignments(new HashSet<>(readers), topics),
+ getExpectedAssignments(new HashSet<>(readers), topics,
offsetsInitializer),
context.getSplitsAssignmentSequence()
.get(expectedAssignmentSeqSize - 1)
.assignment());
}
private void verifyAssignments(
- Map<Integer, Set<TopicPartition>> expectedAssignments,
+ Map<Integer, Collection<KafkaPartitionSplit>> expectedAssignments,
Map<Integer, List<KafkaPartitionSplit>> actualAssignments) {
- actualAssignments.forEach(
- (reader, splits) -> {
- Set<TopicPartition> expectedAssignmentsForReader =
- expectedAssignments.get(reader);
- assertThat(expectedAssignmentsForReader).isNotNull();
-
assertThat(splits.size()).isEqualTo(expectedAssignmentsForReader.size());
- for (KafkaPartitionSplit split : splits) {
- assertThat(expectedAssignmentsForReader)
- .contains(split.getTopicPartition());
+
assertThat(actualAssignments).containsOnlyKeys(expectedAssignments.keySet());
+ SoftAssertions.assertSoftly(
Review Comment:
Here I use soft assertions for assertion on the nested structure of the same
data structure. I haven't found a good way to have all assertions on this one
data structure in one line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
