Au-Miner commented on code in PR #27099:
URL: https://github.com/apache/flink/pull/27099#discussion_r2443931510
##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/join/deltajoin/AsyncDeltaJoinRunner.java:
##########
@@ -191,26 +274,45 @@ public static final class JoinedRowResultFuture
implements ResultFuture<Object>
private final TableFunctionResultFuture<RowData>
joinConditionResultFuture;
private final DataStructureConverter<RowData, Object> resultConverter;
+ private final boolean enableCache;
+ private final DeltaJoinCache cache;
+
private final DelegateResultFuture delegate;
private final boolean treatRightAsLookupTable;
+ private final RowDataKeySelector leftUpsertKeySelector;
+ private final RowDataKeySelector rightUpsertKeySelector;
+
+ private @Nullable RowData streamJoinKey;
private RowData streamRow;
private ResultFuture<RowData> realOutput;
private JoinedRowResultFuture(
BlockingQueue<JoinedRowResultFuture> resultFutureBuffer,
TableFunctionResultFuture<RowData> joinConditionResultFuture,
DataStructureConverter<RowData, Object> resultConverter,
- boolean treatRightAsLookupTable) {
+ boolean enableCache,
+ DeltaJoinCache cache,
+ boolean treatRightAsLookupTable,
Review Comment:
Yes, you are right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
