[
https://issues.apache.org/jira/browse/FLINK-5444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15820553#comment-15820553
]
ASF GitHub Bot commented on FLINK-5444:
---------------------------------------
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3093#discussion_r95749646
--- Diff:
flink-runtime-web/web-dashboard/app/scripts/modules/submit/submit.ctrl.coffee
---
@@ -167,7 +167,7 @@ angular.module('flinkApp')
$scope.uploader['success'] = null
else
$scope.uploader['success'] = "Uploaded!"
- xhr.open("POST", "/jars/upload")
+ xhr.open("POST", "jars/upload")
--- End diff --
Primarily, this makes all server side requests consistent. Further, if you
check in index.coffee, the jobserver URL is set to empty for production, and a
local host string for development purposes. This helps with streamlining
dashboard dev without having to rebuild the maven modules again and again.
This particular case was disabling the dev on submit page. Best to get this
in while you're fixing all urls.
> Flink UI uses absolute URLs.
> ----------------------------
>
> Key: FLINK-5444
> URL: https://issues.apache.org/jira/browse/FLINK-5444
> Project: Flink
> Issue Type: Bug
> Reporter: Joerg Schad
> Assignee: Joerg Schad
>
> The Flink UI has a mixed use of absolute and relative links. See for example
> [here](https://github.com/apache/flink/blob/master/flink-runtime-web/web-dashboard/web/index.html)
> {code:|borderStyle=solid}
> <link rel="icon" type="image/png" href="/images/favicon-16x16.png"
> sizes="16x16">
> <link rel="stylesheet" href="css/vendor.css" type="text/css">
> {code}
> When referencing the UI from another UI, e.g., the DC/OS UI relative links
> are preffered.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
