davidradl commented on code in PR #27105:
URL: https://github.com/apache/flink/pull/27105#discussion_r2448568621
##########
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/state/rocksdb/sstmerge/CompactionTracker.java:
##########
@@ -82,6 +82,10 @@ private synchronized void runIfNoManualCompactions(Runnable
runnable) {
}
}
+ public synchronized void addManualCompaction() {
Review Comment:
can we add some unit tests for this class.
I am curious about the method
```
private synchronized void cancel() {
pendingManualCompactions--;
}
```
If the cancel can be called while it is running then the counter could go
negative - as we have already decremented the pending counter when we increment
the running one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
