watsonjo737 commented on code in PR #4156:
URL: https://github.com/apache/flink-cdc/pull/4156#discussion_r2452078722
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/test/java/org/apache/flink/cdc/connectors/mysql/debezium/DebeziumUtilsTest.java:
##########
@@ -83,6 +89,26 @@ private MySqlSourceConfig getConfig(Properties
jdbcProperties) {
.createConfig(0);
}
+ @ParameterizedTest
+ @MethodSource("sslModeProvider")
+ void testSslModeConversion(MySqlConnectorConfig.SecureConnectionMode
input, SSLMode expected) {
Review Comment:
Thanks @ruanhang1993 , I have added a new test there
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/test/java/org/apache/flink/cdc/connectors/mysql/source/MySqlSourceSSLConnectionITCase.java
which shows how it can be configured, and confirmed that without this fix in
place it fails to run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
