xuyangzhong commented on code in PR #27111:
URL: https://github.com/apache/flink/pull/27111#discussion_r2454417910
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/utils/DeltaJoinUtil.java:
##########
@@ -240,7 +248,28 @@ private static List<List<String>>
getAllIndexesColumnsOfTable(
private static boolean areJoinConditionsSupported(StreamPhysicalJoin join)
{
JoinInfo joinInfo = join.analyzeCondition();
// there must be one pair of join key
- return !joinInfo.pairs().isEmpty();
+ if (joinInfo.pairs().isEmpty()) {
+ return false;
+ }
+
+ // if this join output cdc records, the non-equiv condition must be
applied on upsert key
Review Comment:
By the way, the comment here should emphasize that the columns in the
non-equivalent condition must all come from the same set of upsert keys.
Therefore, I will modify it to:
```If this join outputs cdc records and has non-equiv condition, the
reference columns in the non-equiv condition must come from the same set of
upsert keys.```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
