twalthr opened a new pull request, #27142:
URL: https://github.com/apache/flink/pull/27142
## What is the purpose of the change
This fixes the CastRule infrastructure which has issues detecting identity
casts of complex types such as ROW. Although the planner should eliminate most
identity casts, they sometimes still slip through, which is why detecting them
in the code generation is beneficial for performance. Esp. on heavily nested
ROW structured, which could lead to a significant performance regression
otherwise.
## Brief change log
Change rule evaluation order to give IdentityCastRule precendence.
## Verifying this change
This change is already covered by existing tests, such as CastFunctionITCase.
Additionally, it adds a dedicated CastRuleProviderTest.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): yes
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
