[
https://issues.apache.org/jira/browse/FLINK-5432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15820908#comment-15820908
]
ASF GitHub Bot commented on FLINK-5432:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3090#discussion_r95782207
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileMonitoringFunction.java
---
@@ -282,7 +282,7 @@ private void monitorDirAndForwardSplits(FileSystem fs,
* Returns the paths of the files not yet processed.
* @param fileSystem The filesystem where the monitored directory
resides.
*/
- private Map<Path, FileStatus> listEligibleFiles(FileSystem fileSystem)
throws IOException {
+ private Map<Path, FileStatus> listEligibleFiles(FileSystem fileSystem,
String path) throws IOException {
--- End diff --
I would suggest passing a `Path` here. It is always a safer option to rely
on the this class than on strings.
> ContinuousFileMonitoringFunction is not monitoring nested files
> ---------------------------------------------------------------
>
> Key: FLINK-5432
> URL: https://issues.apache.org/jira/browse/FLINK-5432
> Project: Flink
> Issue Type: Bug
> Components: filesystem-connector
> Affects Versions: 1.2.0
> Reporter: Yassine Marzougui
> Assignee: Yassine Marzougui
> Fix For: 1.2.0, 1.3.0
>
>
> The {{ContinuousFileMonitoringFunction}} does not monitor nested files even
> if the inputformat has NestedFileEnumeration set to true. This can be fixed
> by enabling a recursive scan of the directories in the {{listEligibleFiles}}
> method.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
