Zakelly opened a new pull request, #27157:
URL: https://github.com/apache/flink/pull/27157
## What is the purpose of the change
During incremental checkpoints, the RocksDB/ForSt will upload checkpoint
files based on previous uploaded ssts. But the uploaded ssts are determined via
the checkpoint notifications. If the notification arrives late, it may use
wrong sst files which are already subsumed by the shared state registry. See
FLINK-38574 for one example. This PR fix this.
## Brief change log
- Change the ForSt/RocksDBIncrementalSnapshotStrategy to avoid reusing the
files that has been re-uploaded by following checkpoints.
## Verifying this change
- Added `testCheckpointIsIncrementalWithLateNotification` for both RocksDB
and ForSt.
- Existing `EventTimeWindowCheckpointingITCase.testSlidingTimeWindow` and
`testPreAggregatedTumblingTimeWindow ` will fail occasionally without this fix.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: yes
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
