Poorvankbhatia commented on code in PR #111:
URL:
https://github.com/apache/flink-connector-pulsar/pull/111#discussion_r2466345459
##########
flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/config/SourceConfiguration.java:
##########
@@ -136,7 +137,7 @@ public long getAutoCommitCursorInterval() {
* messages in {@link RecordsWithSplitIds} when meet this timeout and no
message consumed.
*/
public int getFetchOneMessageTime() {
- return fetchOneMessageTime;
+ return (int) fetchOneMessageTime;
Review Comment:
nit: The fetchOneMessageTime field is stored as long but cast to int in the
getter, can it risk overflow for large Duration values? Should we add: Add
validation to reject values > Integer.MAX_VALUE , or can we make this Duration
too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
