ryanvanhuuksloot commented on code in PR #1041:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/1041#discussion_r2467652896
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/diff/FlinkBlueGreenDeploymentSpecDiff.java:
##########
@@ -59,15 +59,15 @@ public BlueGreenDiffType compare() {
FlinkDeploymentSpec leftSpec = left.getTemplate().getSpec();
FlinkDeploymentSpec rightSpec = right.getTemplate().getSpec();
+ DiffResult<FlinkDeploymentSpec> diffResult =
+ new ReflectiveDiffBuilder<>(deploymentMode, leftSpec,
rightSpec).build();
+
// Case 1: FlinkDeploymentSpecs are identical
if (leftSpec.equals(rightSpec)) {
return BlueGreenDiffType.IGNORE;
}
// Case 2 & 3: Delegate to ReflectiveDiffBuilder for nested spec
comparison
Review Comment:
NIT comment lingering, I think we should keep the comment but it needs to
move
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
