davidradl commented on code in PR #27134:
URL: https://github.com/apache/flink/pull/27134#discussion_r2472417185
##########
flink-tests/src/test/java/org/apache/flink/test/streaming/runtime/SinkV2ITCase.java:
##########
@@ -374,19 +374,19 @@ private void
assertUnalignedCheckpointInNonSink(StreamGraph streamGraph) {
IntegerTypeInfo.INT_TYPE_INFO);
}
- private static class BurstingRateLimiter implements RateLimiter {
- private final RateLimiter rateLimiter;
+ private static class BurstingRateLimiter implements RateLimiter<Void> {
+ private final RateLimiter<Void> rateLimiter;
private final int numCheckpointCooldown;
private int cooldown;
public BurstingRateLimiter(int recordPerCycle, int
numCheckpointCooldown) {
- rateLimiter = new GatedRateLimiter(recordPerCycle);
+ rateLimiter = new GatedRateLimiter<>(recordPerCycle);
this.numCheckpointCooldown = numCheckpointCooldown;
}
@Override
- public CompletionStage<Void> acquire() {
- CompletionStage<Void> stage = rateLimiter.acquire();
+ public CompletionStage<Void> acquire(int requestSize) {
Review Comment:
When we say requestSize - does this mean the size of requests? Looking at
the code it seems to relate to the number of futures we want to acquire, if so
I would suggest renaming this. Maybe numberOfFuturesToAcquire.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
