davidradl commented on code in PR #27164:
URL: https://github.com/apache/flink/pull/27164#discussion_r2472614524
##########
flink-python/pyflink/datastream/async_data_stream.py:
##########
@@ -47,14 +48,39 @@ def unordered_wait(
:param output_type: The output data type.
:return: The transformed DataStream.
"""
- AsyncDataStream._validate(data_stream, async_function)
+ return AsyncDataStream.unordered_wait_with_retry(
+ data_stream, async_function, timeout,
async_retry_strategies.NO_RETRY_STRATEGY,
+ capacity, output_type)
+
+ @staticmethod
+ def unordered_wait_with_retry(
+ data_stream: DataStream,
+ async_function: AsyncFunction,
+ timeout: Time,
+ async_retry_strategy: AsyncRetryStrategy,
+ capacity: int = 100,
+ output_type: TypeInformation = None) -> 'DataStream':
+ """
+ Adds an async function with an AsyncRetryStrategy to support retry of
AsyncFunction to the
+ data stream. The order of output stream records may be reordered.
Review Comment:
I assume this is because we hard code
AsyncFunctionDescriptor.OutputMode.UNORDERED. Is there thinking about an
ordered version of this?
wording nit: The order of output stream records may be reordered. -> The
output stream records may be reordered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
