lihaosky commented on code in PR #27154:
URL: https://github.com/apache/flink/pull/27154#discussion_r2479544334


##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/runtime/utils/VectorSearchITCaseBase.java:
##########
@@ -34,8 +36,17 @@
 import static org.assertj.core.api.Assertions.assertThatThrownBy;
 import static org.assertj.core.api.AssertionsForInterfaceTypes.assertThatList;
 
-/** ITCase to verify {@code VECTOR_SEARCH} function. */
-public class VectorSearchITCase extends StreamingTestBase {
+/** Base ITCase to verify {@code VECTOR_SEARCH} function. */
+public abstract class VectorSearchITCaseBase {

Review Comment:
   Looks there's more setup in `StreamingTestBase`: 
https://github.com/apache/flink/blob/master/flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/utils/StreamingTestBase.scala#L44-L46.
 Such as parallelism and object reuse. 
   
   Same for `BatchTestBase`. Do we care about those?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to