SteveStevenpoor commented on code in PR #27166:
URL: https://github.com/apache/flink/pull/27166#discussion_r2483369699
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/JoinToMultiJoinRule.java:
##########
@@ -532,6 +596,8 @@ private void addJoinKeysByOperand(
joinKeys.add(qualifiedName.get(qualifiedName.size() - 1) + "."
+ fieldName);
}
}
+
Review Comment:
> if we construct keys this way, will it work in case of joins on nested
fields? Or do we have any test for this?
As far as I know, Calcite adds projections to handle nested fields. Since we
won't match
[here](https://github.com/apache/flink/pull/27166/files#diff-44d9c5d7695b96ec29f833777fcfd24c78c5e0a9d0dab52d4b5403ccd3a7d165L430),
MultiJoin will not combine inputs. I added a test with nested fields in the
last update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
