GitHub user gallenvara opened a pull request:

    https://github.com/apache/flink/pull/3110

    [FLINK-2184] Cannot get last element with maxBy/minBy.

    Thanks for contributing to Apache Flink. Before you open your pull request, 
please take the following check list into consideration.
    If your changes take all of the items into account, feel free to open your 
pull request. For more information and/or questions please refer to the [How To 
Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful 
description of your changes.
    
    - [X] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira 
title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the 
JIRA id)
    
    - [X] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [ ] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis 
build has passed
    
    Extend the minBy/maxBy with first parameter. @fhueske sorry for the late 
update for this pr, can you help with review work?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gallenvara/flink flink-2184

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3110.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3110
    
----
commit 8ae9bb689320a0b5b3fe199ecc61c62504ff0e7d
Author: gallenvara <gallenv...@126.com>
Date:   2016-05-09T11:51:24Z

    Extend minBy/maxBy methods to support returning last element.

commit e04ae6e2bfad1c52460dc742be41153dd012b291
Author: gaolun.gl <gaolun...@alibaba-inc.com>
Date:   2017-01-13T04:10:08Z

    update pr of [FLINK-2184] Cannot get last element with maxBy/minBy.

commit 8bff4dda475bfecaaa2b5efeab84c1afc87d0f5f
Author: gaolun.gl <gaolun...@alibaba-inc.com>
Date:   2017-01-13T04:12:19Z

    Merge remote-tracking branch 'origin/flink-2184' into flink-2184
    
    # Conflicts:
    #   
flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/AllWindowedStream.scala
    #   
flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/KeyedStream.scala
    #   
flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/WindowedStream.scala

commit 71d2c23574d42cedb558ca991ebd87f814a16fde
Author: gaolun.gl <gaolun...@alibaba-inc.com>
Date:   2017-01-13T04:26:45Z

    update pr of [FLINK-2184] Cannot get last element with maxBy/minBy.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to