[ 
https://issues.apache.org/jira/browse/FLINK-4912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15821466#comment-15821466
 ] 

ASF GitHub Bot commented on FLINK-4912:
---------------------------------------

Github user uce commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3113#discussion_r95960106
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/execution/ExecutionState.java
 ---
    @@ -25,16 +25,23 @@
      * <pre>{@code
      *
      *     CREATED  -> SCHEDULED -> DEPLOYING -> RUNNING -> FINISHED
    - *                     |            |          |
    - *                     |            |   +------+
    - *                     |            V   V
    - *                     |         CANCELLING -----+----> CANCELED
    - *                     |                         |
    - *                     +-------------------------+
    + *            |         |            |          |
    + *            |         |            |   +------+
    + *            |         |            V   V
    + *            |         |         CANCELLING -----+----> CANCELED
    + *            |         |                         |
    + *            |        +-------------------------+
    + *            |
    + *            |                                   ... -> FAILED
    + *           V
    + *    RECONCILING  -> RUNNING | FINISHED | CANCELED | FAILED
      *
    - *                                               ... -> FAILED
      * }</pre>
      *
    + * <p>It is possible to enter the {@code RECONCILING} state from {@code 
CREATED}
    --- End diff --
    
    I think it would be best to move this paragraph below the other paragraphs 
below (below line 48).
    
    A general note: I think for Javadocs it's enough to just have the opening 
`<p>` tag like this:
    
    ```
    <p>Start here...
    ...continue and not closing tag at the end.
    ```


> Introduce RECONCILING state in ExecutionGraph
> ---------------------------------------------
>
>                 Key: FLINK-4912
>                 URL: https://issues.apache.org/jira/browse/FLINK-4912
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Distributed Coordination
>            Reporter: Stephan Ewen
>            Assignee: Zhijiang Wang
>
> This is part of the non-disruptive JobManager failure recovery.
> I suggest to add a JobStatus and ExecutionState {{RECONCILING}}.
> If a job is started on a that JobManager for master recovery (tbd how to 
> determine that) the {{ExecutionGraph}} and the {{Execution}}s start in the 
> reconciling state.
> From {{RECONCILING}}, tasks can go to {{RUNNING}} (execution reconciled with 
> TaskManager) or to {{FAILED}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to