snuyanzin commented on code in PR #27183:
URL: https://github.com/apache/flink/pull/27183#discussion_r2485023361
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/utils/DiffRepository.java:
##########
@@ -188,18 +197,42 @@ public class DiffRepository {
* share the same diff-repository: if the repository gets loaded once per
test case, then only
* one diff is recorded.
*/
- private static final Map<Class<?>, DiffRepository> MAP_CLASS_TO_REPOSITORY
= new HashMap<>();
+ private static final LoadingCache<Key, DiffRepository> REPOSITORY_CACHE =
Review Comment:
Mostly synced with updates from Calcite version
(https://github.com/apache/calcite/blob/main/testkit/src/main/java/org/apache/calcite/test/DiffRepository.java),
also fixed some bugs both here and in Calcite, like e.g.
https://github.com/apache/calcite/pull/4612
There are still some differences between Flink and Calcite versions however
now much less.
Probably need a separate task to try to backport Flink's features to Calcite
and drop it from Flink repo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
