[ 
https://issues.apache.org/jira/browse/FLINK-5155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15821522#comment-15821522
 ] 

ASF GitHub Bot commented on FLINK-5155:
---------------------------------------

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/3108
  
    I think this is good, +1
    
    What would be good is to add a line in the comment of the constructor that 
says that the state returns `null` if there is no value present, yet, for the 
current key.


> Deprecate ValueStateDescriptor constructors with default value
> --------------------------------------------------------------
>
>                 Key: FLINK-5155
>                 URL: https://issues.apache.org/jira/browse/FLINK-5155
>             Project: Flink
>          Issue Type: Improvement
>          Components: Streaming
>            Reporter: Aljoscha Krettek
>
> Having the default value in the descriptor is problematic with some 
> serialisers and we don't lose a feature because users can always check for 
> the null value and initialise with their own default value if necessary. 
> Right now, we're always forcing people to specify a default value even though 
> they don't need one.
> Of course, we should add constructors without a default value.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to