[ 
https://issues.apache.org/jira/browse/FLINK-4988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15821640#comment-15821640
 ] 

ASF GitHub Bot commented on FLINK-4988:
---------------------------------------

Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3112#discussion_r95977656
  
    --- Diff: 
flink-connectors/flink-connector-elasticsearch5/src/test/java/org/apache/flink/streaming/connectors/elasticsearch5/ElasticsearchSinkITCase.java
 ---
    @@ -0,0 +1,68 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + * <p>
    + * http://www.apache.org/licenses/LICENSE-2.0
    + * <p>
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.flink.streaming.connectors.elasticsearch5;
    +
    +import 
org.apache.flink.streaming.connectors.elasticsearch.ElasticsearchSinkBase;
    +import 
org.apache.flink.streaming.connectors.elasticsearch.ElasticsearchSinkFunction;
    +import 
org.apache.flink.streaming.connectors.elasticsearch.ElasticsearchSinkTestBase;
    +import org.junit.Test;
    +
    +import java.net.InetAddress;
    +import java.net.InetSocketAddress;
    +import java.util.ArrayList;
    +import java.util.List;
    +import java.util.Map;
    +
    +public class ElasticsearchSinkITCase extends ElasticsearchSinkTestBase {
    +
    +   @Test
    +   public void testTransportClient() throws Exception {
    +           runTransportClientTest();
    +   }
    +
    +   @Test
    +   public void testNullTransportClient() throws Exception {
    +           runNullTransportClientTest();
    +   }
    +
    +   @Test
    +   public void testEmptyTransportClient() throws Exception {
    +           runEmptyTransportClientTest();
    +   }
    +
    +   @Test
    +   public void testTransportClientFails() throws Exception {
    +           runTransportClientFailsTest();
    +   }
    +
    +   @Override
    +   protected <T> ElasticsearchSinkBase<T> 
createElasticsearchSink(Map<String, String> userConfig,
    +                                                                           
                                                List<InetSocketAddress> 
transportAddresses,
    +                                                                           
                                                ElasticsearchSinkFunction<T> 
elasticsearchSinkFunction) {
    --- End diff --
    
    Do you mean empty line? I don't think there are trailing whitespaces.
    It isn't an empty line actually, the method parameters are at the right.
    Need to drag the horizontal scroll to see it, otherwise on the IDE the seem 
to be aligned.


> Elasticsearch 5.x support
> -------------------------
>
>                 Key: FLINK-4988
>                 URL: https://issues.apache.org/jira/browse/FLINK-4988
>             Project: Flink
>          Issue Type: New Feature
>            Reporter: Mike Dias
>
> Elasticsearch 5.x was released: 
> https://www.elastic.co/blog/elasticsearch-5-0-0-released



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to