leonardBang commented on code in PR #4169:
URL: https://github.com/apache/flink-cdc/pull/4169#discussion_r2509734066
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-cdc-base/src/main/java/org/apache/flink/cdc/connectors/base/source/assigner/StreamSplitAssigner.java:
##########
@@ -129,9 +129,11 @@ public void onFinishedSplits(Map<String, Offset>
splitFinishedOffsets) {
@Override
public void addSplits(Collection<SourceSplitBase> splits) {
Review Comment:
+1 to deal with this logic in addSplitsBack later, but we can merge this PR
firstly and then refactor with MySQL together, WDYT? @loserwang1024 @gong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
