Myasuka commented on code in PR #27186:
URL: https://github.com/apache/flink/pull/27186#discussion_r2519277018
##########
flink-runtime/src/test/java/org/apache/flink/runtime/util/SerializedThrowableTest.java:
##########
@@ -179,4 +187,60 @@ void testCopySuppressed() {
.isInstanceOf(SerializedThrowable.class)
.hasMessage("java.lang.Exception: suppressed");
}
+
+ @Test
+ void testCyclicSuppressedThrowableSerialized() {
+ SerializedThrowable serializedThrowable = new
SerializedThrowable(mockThrowable());
+ assertThat(serializedThrowable).isNotNull();
+ }
+
+ @Test
+ void testCyclicSuppressedThrowableConcurrentSerialized() throws
InterruptedException {
Review Comment:
I don't this test is stable without timeout limit, if we do not fix the
original code in
`flink-core/src/main/java/org/apache/flink/util/SerializedThrowable.java`, this
test would run endlessly without quit properly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
