GreatEugenius commented on code in PR #314:
URL: https://github.com/apache/flink-agents/pull/314#discussion_r2533030124
##########
api/src/main/java/org/apache/flink/agents/api/prompt/Prompt.java:
##########
@@ -76,6 +77,14 @@ public String formatString(Map<String, String> kwargs) {
});
}
+ public List<ChatMessage> formatMessages(String defaultRoleValue,
Map<String, Object> kwargs) {
Review Comment:
I don't believe we reuse the `formatMessages(MessageRole defaultRole,
Map<String, String> kwargs)`. In the Java chat model, the logic is implemented
in the `chat` method of BaseChatModelSetup.java. However, for the Python chat
model, we need to implement it here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
