SteveStevenpoor commented on PR #27166: URL: https://github.com/apache/flink/pull/27166#issuecomment-3540568585
Hey @snuyanzin! Thanks for the review — most of the comments are already addressed. Regarding `NoCommonJoinKeyException`: I think we should keep it where it is, since `AttributeBasedJoinKeyExtractor` is used in both exec and physical rules, and this exception needs to be thrown from both places. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
