snuyanzin commented on code in PR #27231:
URL: https://github.com/apache/flink/pull/27231#discussion_r2533420072
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/inference/TypeInferenceOperandChecker.java:
##########
@@ -240,10 +246,28 @@ private void insertImplicitCasts(SqlCallBinding
callBinding, List<DataType> expe
/** Adopted from {@link
org.apache.calcite.sql.validate.implicit.AbstractTypeCoercion}. */
private SqlNode castTo(SqlNode node, RelDataType type) {
- return SqlStdOperatorTable.CAST.createCall(
- SqlParserPos.ZERO,
- node,
-
SqlTypeUtil.convertTypeToSpec(type).withNullable(type.isNullable()));
+ final SqlDataTypeSpec dataType;
+ if (type instanceof RawRelDataType) {
+ dataType = createRawDataTypeSpec((RawRelDataType) type);
+ } else {
+ dataType =
SqlTypeUtil.convertTypeToSpec(type).withNullable(type.isNullable());
Review Comment:
For every Calcite class there is a reason to be there and the reason is
mentioned in class header and this class could/should be removed once the
reason is fixed.
example for SqlTypeUtil
https://github.com/apache/flink/blob/7de3392b47096fb0f4163b9217a5d344b7361791/flink-table/flink-table-planner/src/main/java/org/apache/calcite/sql/type/SqlTypeUtil.java#L71-L81
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
