[
https://issues.apache.org/jira/browse/FLINK-5489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15822486#comment-15822486
]
ASF GitHub Bot commented on FLINK-5489:
---------------------------------------
GitHub user haohui opened a pull request:
https://github.com/apache/flink/pull/3123
[FLINK-5489] maven release:prepare fails due to invalid JDOM comments…
When I was trying to publish Flink to our internal artifactory, I found out
that maven release:prepare has failed because the plugin complains about the
some of the comments pom.xml do not conform with the JDOM format (More
information on the JIRA).
This PR fixes the issue by making all comments conform to the JDOM format.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/haohui/flink FLINK-5489
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3123.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3123
----
commit ba26954891b4ce1d968a90e7c89a04681dca6b65
Author: Haohui Mai <[email protected]>
Date: 2017-01-13T22:48:35Z
[FLINK-5489] maven release:prepare fails due to invalid JDOM comments in
pom.xml.
----
> maven release:prepare fails due to invalid JDOM comments in pom.xml
> -------------------------------------------------------------------
>
> Key: FLINK-5489
> URL: https://issues.apache.org/jira/browse/FLINK-5489
> Project: Flink
> Issue Type: Bug
> Affects Versions: 1.2.0, 1.3.0
> Reporter: Haohui Mai
> Priority: Minor
> Labels: newbie
>
> When I was trying to publish Flink to our internal artifactory, I found out
> that {{maven release:prepare}} has failed because the plugin complains about
> the some of the comments pom.xml do not conform with the JDOM format:
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-release-plugin:2.4.2:prepare (default-cli) on
> project flink-parent: Execution default-cli of goal
> org.apache.maven.plugins:maven-release-plugin:2.4.2:prepare failed: The data
> "-
> [ERROR] This module is used a dependency in the root pom. It activates
> shading for all sub modules
> [ERROR] through an include rule in the shading configuration. This assures
> that Maven always generates
> [ERROR] an effective pom for all modules, i.e. get rid of Maven properties.
> In particular, this is needed
> [ERROR] to define the Scala version property in the root pom but not let the
> root pom depend on Scala
> [ERROR] and thus be suffixed along with all other modules.
> [ERROR] " is not legal for a JDOM comment: Comment data cannot start with a
> hyphen.
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
