davidradl commented on code in PR #27251:
URL: https://github.com/apache/flink/pull/27251#discussion_r2541318905
##########
flink-table/flink-sql-parser/src/test/java/org/apache/flink/sql/parser/FlinkSqlParserImplTest.java:
##########
@@ -3475,6 +3475,209 @@ void testModelInFunctionNamedArgs() {
+ "FROM TABLE(`ML_PREDICT`(`INPUT` => (TABLE
`MY_TABLE`), `MODEL` => (MODEL `MY_MODEL`)))");
}
+ //
=====================================================================================
+ // Connection DDL/DQL Tests
+ //
=====================================================================================
+
+ @Test
+ void testCreateConnection() {
+ sql("create connection conn1\n"
+ + " COMMENT 'connection_comment'\n"
+ + " WITH (\n"
+ + " 'type'='basic',\n"
+ + " 'url'='http://example.com',\n"
+ + " 'username'='user1',\n"
+ + " 'password'='pass1'\n"
+ + " )\n")
+ .ok(
+ "CREATE CONNECTION `CONN1`\n"
+ + "COMMENT 'connection_comment' WITH (\n"
+ + " 'type' = 'basic',\n"
+ + " 'url' = 'http://example.com',\n"
+ + " 'username' = 'user1',\n"
+ + " 'password' = 'pass1'\n"
+ + ")");
+ }
+
+ @Test
+ void testCreateConnectionIfNotExists() {
+ sql("create connection if not exists conn1\n"
+ + " WITH (\n"
+ + " 'type'='bearer',\n"
+ + " 'token'='my_token'\n"
+ + " )\n")
+ .ok(
+ "CREATE CONNECTION IF NOT EXISTS `CONN1` WITH (\n"
+ + " 'type' = 'bearer',\n"
+ + " 'token' = 'my_token'\n"
+ + ")");
+ }
+
+ @Test
+ void testCreateTemporaryConnection() {
+ sql("create temporary connection conn1\n"
+ + " WITH (\n"
+ + " 'type'='oauth',\n"
+ + " 'client_id'='client1'\n"
+ + " )\n")
+ .ok(
+ "CREATE TEMPORARY CONNECTION `CONN1` WITH (\n"
+ + " 'type' = 'oauth',\n"
+ + " 'client_id' = 'client1'\n"
+ + ")");
+ }
+
+ @Test
+ void testCreateSystemConnection() {
+ sql("create ^system^ connection conn1\n"
+ + " WITH (\n"
+ + " 'type'='basic',\n"
+ + " 'url'='http://example.com'\n"
+ + " )\n")
+ .fails(
+ "(?s)CREATE SYSTEM CONNECTION is not supported, system
connection can only be registered as temporary connection, you can use CREATE
TEMPORARY SYSTEM CONNECTION instead\\..*");
+ }
+
+ @Test
+ void testCreateTemporarySystemConnection() {
+ sql("create temporary system connection conn1\n"
+ + " WITH (\n"
+ + " 'type'='custom_type',\n"
+ + " 'api_key'='key123'\n"
+ + " )\n")
+ .ok(
+ "CREATE TEMPORARY SYSTEM CONNECTION `CONN1` WITH (\n"
+ + " 'type' = 'custom_type',\n"
+ + " 'api_key' = 'key123'\n"
+ + ")");
+ }
+
+ @Test
+ void testCreateConnectionWithQualifiedName() {
+ sql("create connection catalog1.db1.conn1\n"
+ + " WITH ('type'='basic',
'url'='http://example.com')\n")
+ .ok(
+ "CREATE CONNECTION `CATALOG1`.`DB1`.`CONN1` WITH (\n"
+ + " 'type' = 'basic',\n"
+ + " 'url' = 'http://example.com'\n"
+ + ")");
+ }
+
+ @Test
+ void testDropConnection() {
+ sql("drop connection conn1").ok("DROP CONNECTION `CONN1`");
+ sql("drop connection db1.conn1").ok("DROP CONNECTION `DB1`.`CONN1`");
+ sql("drop connection catalog1.db1.conn1").ok("DROP CONNECTION
`CATALOG1`.`DB1`.`CONN1`");
+ }
+
+ @Test
+ void testDropConnectionIfExists() {
+ sql("drop connection if exists catalog1.db1.conn1")
+ .ok("DROP CONNECTION IF EXISTS `CATALOG1`.`DB1`.`CONN1`");
+ }
+
+ @Test
+ void testDropTemporaryConnection() {
+ sql("drop temporary connection conn1").ok("DROP TEMPORARY CONNECTION
`CONN1`");
+ sql("drop temporary connection if exists conn1")
+ .ok("DROP TEMPORARY CONNECTION IF EXISTS `CONN1`");
+ }
+
+ @Test
+ void testDropTemporarySystemConnection() {
Review Comment:
how does `drop system connection conn1 fail?` ; maybe have a test for this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
