davidradl commented on code in PR #27252:
URL: https://github.com/apache/flink/pull/27252#discussion_r2541735252
##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/join/deltajoin/DeltaJoinCache.java:
##########
@@ -87,7 +87,7 @@ public void registerMetrics(MetricGroup metricGroup) {
:
Long.valueOf(leftHitCount.get()).doubleValue()
/ leftRequestCount.get());
metricGroup.<Long, Gauge<Long>>gauge(
- LEFT_CACHE_METRIC_PREFIX + METRIC_REQUEST_COUNT,
rightRequestCount::get);
+ LEFT_CACHE_METRIC_PREFIX + METRIC_REQUEST_COUNT,
leftRequestCount::get);
Review Comment:
Is the idea you are adding unit tests later? It would be best to add the
tests t the same time as the fix I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
