[
https://issues.apache.org/jira/browse/FLINK-38497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18039355#comment-18039355
]
Martijn Visser edited comment on FLINK-38497 at 11/19/25 12:18 PM:
-------------------------------------------------------------------
[~leonard] [~kunni] Looks like this has introduced a breaking change for
connectors, since the Kafka connector won't compile as-is against Flink
2.2-SNAPSHOT
https://github.com/apache/flink-connector-kafka/actions/runs/19500518177/job/55813208476#step:16:197
{code:java}
Error: Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.8.0:testCompile
(default-testCompile) on project flink-connector-kafka: Compilation failure
Error:
/home/runner/work/flink-connector-kafka/flink-connector-kafka/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaSinkITCase.java:[978,38]
<anonymous
org.apache.flink.connector.kafka.sink.KafkaSinkITCase$ThrottleUntilFirstCheckpointStrategy$1>
is not abstract and does not override abstract method acquire(int) in
org.apache.flink.api.connector.source.util.ratelimit.RateLimiter
Error: -> [Help 1]
{code}
Edit: I see that this was noted already in the FLIP. Could we not have added a
default method for the original interface, in order to not break connectors?
was (Author: martijnvisser):
[~leonard] [~kunni] Looks like this has introduced a breaking change for
connectors, since the Kafka connector won't compile as-is against Flink
2.2-SNAPSHOT
https://github.com/apache/flink-connector-kafka/actions/runs/19500518177/job/55813208476#step:16:197
{code:java}
Error: Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.8.0:testCompile
(default-testCompile) on project flink-connector-kafka: Compilation failure
Error:
/home/runner/work/flink-connector-kafka/flink-connector-kafka/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaSinkITCase.java:[978,38]
<anonymous
org.apache.flink.connector.kafka.sink.KafkaSinkITCase$ThrottleUntilFirstCheckpointStrategy$1>
is not abstract and does not override abstract method acquire(int) in
org.apache.flink.api.connector.source.util.ratelimit.RateLimiter
Error: -> [Help 1]
{code}
> FLIP-535:Introduce RateLimiter to Source
> ----------------------------------------
>
> Key: FLINK-38497
> URL: https://issues.apache.org/jira/browse/FLINK-38497
> Project: Flink
> Issue Type: New Feature
> Components: API / Core
> Affects Versions: 2.1.0
> Reporter: Yanquan Lv
> Assignee: Yanquan Lv
> Priority: Major
> Labels: pull-request-available
> Fix For: 2.2.0
>
>
> Ticket for [FLIP-535: Introduce RateLimiter to
> Source|https://cwiki.apache.org/confluence/display/FLINK/FLIP-535%3A+Introduce+RateLimiter+to+Source]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
