lurongjiang commented on code in PR #26258:
URL: https://github.com/apache/flink/pull/26258#discussion_r2547415690
##########
flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/nonha/standalone/StandaloneHaServices.java:
##########
@@ -61,7 +61,7 @@ public StandaloneHaServices(
checkNotNull(resourceManagerAddress, "resourceManagerAddress");
this.dispatcherAddress = checkNotNull(dispatcherAddress,
"dispatcherAddress");
this.clusterRestEndpointAddress =
- checkNotNull(clusterRestEndpointAddress,
clusterRestEndpointAddress);
+ checkNotNull(clusterRestEndpointAddress,
"clusterRestEndpointAddress");
Review Comment:
Thank you for the feedback! I apologize for the confusion.
I've closed this PR because my branch had fallen significantly behind
upstream/master, which caused a large number of unintended file changes when I
tried to rebase. To resolve this, I've created a new, clean PR with a fresh
branch based on the latest master: #27258.
The new PR contains all the requested changes (the NPE fix and the unit
test). Could you please review the new one instead? Thanks again for your time!
Best regards
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
