xli1996 commented on code in PR #320:
URL: https://github.com/apache/flink-agents/pull/320#discussion_r2547506616
##########
plan/src/main/java/org/apache/flink/agents/plan/tools/SchemaUtils.java:
##########
@@ -61,7 +61,9 @@ public static String generateSchema(Method method) throws
JsonProcessingExceptio
}
Map<String, Object> paramSchema = getParamSchema(param);
- paramSchema.put("description", paramDescription);
+ if (paramDescription != null) {
Review Comment:
I hit the issue when my Tool annotation has no description, seems it just
skip
```
if (!toolParam.description().isEmpty()) {
paramDescription = toolParam.description();
}
```
and stay null, maybe we can just remove `if
(!toolParam.description().isEmpty()) {`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
