davidradl commented on code in PR #57:
URL:
https://github.com/apache/flink-connector-mongodb/pull/57#discussion_r2556388769
##########
.github/workflows/push_pr.yml:
##########
@@ -29,8 +29,8 @@ jobs:
strategy:
matrix:
mongodb: [ mongodb4, mongodb5, mongodb6, mongodb7 ]
- flink: [ 1.19-SNAPSHOT, 1.20-SNAPSHOT ]
- jdk: [ '8, 11, 17, 21' ]
+ flink: [ 2.1-SNAPSHOT ]
Review Comment:
I would look to the way that the [Kafka connector
](https://github.com/apache/flink-connector-kafka/blob/3370960901a4034e48579e8024b0b843dec34b80/.github/workflows/push_pr.yml#L31)
does these github actions; i.e. the push_pr should check against releases not
snapshot levels of Flink
Namely:
```
compile_and_test:
strategy:
matrix:
flink: &flink_versions [ 2.0.1, 2.1.1 ]
jdk: &jdk_versions [ '11, 17, 21' ]
```
Then amend the weekly github action in the style of the Kafka connector
including adding in`flink: 2.2-SNAPSHOT`, to check it works with the latest
Flink
We have also made a similar change to the JDBC connector recently. fyi
@ferenc-csaky
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
