[
https://issues.apache.org/jira/browse/FLINK-5118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823250#comment-15823250
]
ASF GitHub Bot commented on FLINK-5118:
---------------------------------------
Github user xhumanoid commented on the issue:
https://github.com/apache/flink/pull/3106
@zentol
what do you think about remove
if (numBytesOut != null) {
and replace
numBytesOut = metrics.getNumBytesOutCounter();
with
+ if (metrics.getNumBytesOutCounter() != null) {
+ numBytesOut = metrics.getNumBytesOutCounter();
+ } else {
+ numBytesOut = new NullCounter();
+ }
where NullCounter have empty implementation for every method,
prof:
we do null check in one place, because sometime we may forget to do it
cons:
sometimes we broke devirtualization and inlining for counter.inc(..) method
> Inconsistent records sent/received metrics
> ------------------------------------------
>
> Key: FLINK-5118
> URL: https://issues.apache.org/jira/browse/FLINK-5118
> Project: Flink
> Issue Type: Bug
> Components: Metrics, Webfrontend
> Affects Versions: 1.2.0, 1.3.0
> Reporter: Ufuk Celebi
> Assignee: Chesnay Schepler
> Fix For: 1.2.0, 1.3.0
>
>
> In 1.2-SNAPSHOT running a large scale job you see that the counts for
> send/received records are inconsistent, e.g. in a simple word count job we
> see more received records/bytes than we see sent. This is a regression from
> 1.1 where everything works as expected.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
