lvyanquan commented on PR #4179: URL: https://github.com/apache/flink-cdc/pull/4179#issuecomment-3579452495
> but I'm a little confused about how the `testGettingFlinkConfiguration` case works. > What about storing Flink configurations from context in the mocked factory and validating it later? When invoking createDataSource/createDataSink method, the `execution.target` parameter in FlinkConf is validated. If the value does not meet expectations (this parameter has no default value and will return `null` if not properly assigned), an exception will be thrown. I prefer not to store context.getFlinkConf() for subsequent validation, as this would require introducing a static variable, which slightly reduces the testability and scalability of the code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
